Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md #11170

Merged
merged 1 commit into from
Nov 26, 2018
Merged

content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md #11170

merged 1 commit into from
Nov 26, 2018

Conversation

YouthLab
Copy link

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 22, 2018 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit f0fdeb2

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bf8ba0041174f54e3e21d0d

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 22, 2018
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Nov 22, 2018
@YouthLab YouthLab mentioned this pull request Nov 22, 2018
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2018
@markthink
Copy link

@YouthLab 比上次好很多，有时间在更新一下。

@YouthLab
Copy link
Author

@YouthLab 比上次好很多，有时间在更新一下。

好的

@idealhack idealhack added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 23, 2018
tengqm
tengqm requested changes Nov 23, 2018
View reviewed changes
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Outdated Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Outdated Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Outdated Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Outdated Show resolved Hide resolved
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2018
@idealhack idealhack added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Nov 24, 2018
@markthink markthink changed the base branch from dev-1.13 to release-1.12 November 26, 2018 07:17
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 26, 2018
@markthink markthink changed the base branch from release-1.12 to dev-1.13 November 26, 2018 07:29
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2018
@markthink
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markthink
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: xiangpengzhao

If they are not already assigned, you can assign the PR to them by writing /assign @xiangpengzhao in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markthink markthink merged commit fdce2f5 into kubernetes:dev-1.13 Nov 26, 2018
@tengqm
Copy link
Contributor

tengqm commented Nov 27, 2018

类似 master 节点、control plane 这类术语还是应该翻译的，与其它译者保持一致。

@idealhack idealhack removed tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@tengqm tengqm tengqm requested changes

@idealhack idealhack Awaiting requested review from idealhack

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@markthink markthink

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YouthLab @k8sio-netlify-preview-bot @markthink @k8s-ci-robot @tengqm @idealhack