-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resources folder from Git #10561
Remove resources folder from Git #10561
Conversation
/assign @zparnold |
Deploy preview for kubernetes-io-master-staging ready! Built with commit e73c43f https://deploy-preview-10561--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit d57ed67 https://deploy-preview-10561--kubernetes-io-master-staging.netlify.com |
@lucperkins Do you want to wait for review by @zparnold. Or would it be OK for me to just go ahead and merge this? |
@steveperry-53 Feel free to approve. This folder is definitely not being used currently. |
Agree about the potential for reducing confusion (I know the presence of the folder when I build locally has been an issue for me ...) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Somehow the
resources
folder keeps ending up inmaster
(likely due to merges). This PR adds that folder to.gitignore
to prevent this from happening.It probably doesn't hurt to have that folder around but it's a potential source of confusion so better to eliminate it until we need it.