Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resources folder from Git #10561

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Remove resources folder from Git #10561

merged 2 commits into from
Nov 16, 2018

Conversation

lucperkins
Copy link
Contributor

Somehow the resources folder keeps ending up in master (likely due to merges). This PR adds that folder to .gitignore to prevent this from happening.

It probably doesn't hurt to have that folder around but it's a potential source of confusion so better to eliminate it until we need it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 9, 2018
@lucperkins
Copy link
Contributor Author

/assign @zparnold

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e73c43f

https://deploy-preview-10561--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 9, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d57ed67

https://deploy-preview-10561--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor

@lucperkins Do you want to wait for review by @zparnold. Or would it be OK for me to just go ahead and merge this?

@lucperkins
Copy link
Contributor Author

lucperkins commented Oct 29, 2018

@steveperry-53 Feel free to approve. This folder is definitely not being used currently.

@Bradamant3
Copy link
Contributor

Agree about the potential for reducing confusion (I know the presence of the folder when I build locally has been an issue for me ...)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 95953bb into kubernetes:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants