Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit page buttons #10517

Merged

Conversation

chenopis
Copy link
Contributor

@chenopis chenopis commented Oct 5, 2018

The "Edit This Page" button at the bottom of the page is broken. Currently, it uses /docs/editdocs#, e.g. https://kubernetes.io/docs/editdocs#docs/contribute/style/style-guide.md, but it should be like the one at the top of the page, e.g. https://github.com/kubernetes/website/edit/master/content/en/docs/contribute/style/style-guide.md

Also, the edit button at the top of the page has the en language hardcoded into the URL.

screen shot 2018-10-05 at 1 40 12 pm

Preview: https://deploy-preview-10517--kubernetes-io-master-staging.netlify.com/docs/contribute/style/style-guide/

@chenopis chenopis self-assigned this Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2018
@chenopis chenopis force-pushed the chenopis-patch-edit-button branch from bde18ca to 8d302a7 Compare October 5, 2018 20:51
@chenopis chenopis force-pushed the chenopis-patch-edit-button branch 3 times, most recently from 0f549e6 to f8bdb2e Compare October 5, 2018 21:37
@chenopis chenopis force-pushed the chenopis-patch-edit-button branch from f8bdb2e to 9a35c77 Compare October 5, 2018 21:48
@chenopis chenopis changed the title Fix edit page button at bottom of pages. Fix edit page buttons Oct 5, 2018
@mdlinville
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 58aa2d5 into kubernetes:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants