Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynatrace as an example of DaemonSet usage #10077

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

aloismayr
Copy link
Contributor

Just adding Dynatrace as one other monitoring agent that is rolled out via a DaemonSet

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 24, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f2db6c8

https://deploy-preview-10077--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Member

@aloismayr please sign the CLA

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018
@aloismayr
Copy link
Contributor Author

@jimangel just sent a corporate CLA to cla-at-cncf.io

@Bradamant3
Copy link
Contributor

@aloismayr you might need to try some of the trouble-shooting instructions ^^ to get the CLA properly registered.

@aloismayr
Copy link
Contributor Author

I can find the signed CLA in the LinuxFoundation portal. Also my user is registered as contributor.
image
Anything else I could check?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2018
@jimangel
Copy link
Member

@aloismayr looks like it just might have been a timing issue because it's good now. Just waiting on a approved label from @Bradamant3 or another approver.

@tengqm
Copy link
Contributor

tengqm commented Sep 5, 2018

/lgtm
/approve
Thanks.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 133239d into kubernetes:master Sep 5, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants