Skip to content

add new turnkey cloud solution to setup: ICP on multiple clouds #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2018
Merged

add new turnkey cloud solution to setup: ICP on multiple clouds #10034

merged 3 commits into from
Sep 25, 2018

Conversation

bradtopol
Copy link
Contributor

add new turnkey cloud solution to setup: ICP on multiple clouds

Signed-off-by: Brad Topol btopol@us.ibm.com

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.
For 1.12 Features: set Milestone to 1.12 and Base Branch to release-1.12
Help editing and submitting pull requests: https://deploy-preview-9510--kubernetes-io-master-staging.netlify.com/docs/contribute/start/#submit-a-pull-request.
Help choosing which branch to use, see
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@bradtopol
add new turnkey cloud solution to setup: ICP on
24850ab 
multiple clouds

Signed-off-by: Brad Topol <btopol@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2018
@bradtopol bradtopol added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 22, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a4c9800

https://deploy-preview-10034--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Contributor Author

Hi @zparnold I wanted to get this PR opened and in the queue to meet your Tuesday deadline for opened PRs going into 1.12. The only thing that might change on this is the URL it points to. I will find out soon and update this.

@bradtopol bradtopol removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2018
@bradtopol
Copy link
Contributor Author

/retest

@bradtopol
Copy link
Contributor Author

Hi @zparnold this is now ready to be merged. I checked the links. This content is appropriate for both master and 1.12. Thanks!

@tengqm
Copy link
Contributor

tengqm commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@zparnold
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit 039f654 into kubernetes:master Sep 25, 2018
@stacyped
Copy link
Contributor

Hi @zparnold @bradtopol, I don't see these changes on the live Kubernetes site. Can we get ICP to be listed under "Turnkey Cloud Solutions" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictune erictune Awaiting requested review from erictune

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@tengqm tengqm

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bradtopol @k8sio-netlify-preview-bot @tengqm @zparnold @k8s-ci-robot @stacyped