Skip to content

Set clear expectations for PR review feedback #5620

Closed
@zacharysarah

Description

@zacharysarah

This is a...

  • Feature Request
  • Bug Report

Problem: There's no clear expectation about who does what during PR reviews.

Proposed Solution: Update the README and the contribution guidelines to:

  1. Clarify that PR reviewers are responsible for providing clear, actionable feedback.
  2. Clarify that PR owners are responsible for implementing feedback.
  3. Update the new PR template to work around the GitHub UI bug for allowing edits from maintainers.

Page to Update:

https://github.com/kubernetes/kubernetes.github.io/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions