On Go 1.21, use clear() to clear sets #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/S
skitt
force-pushed
the
golang-1.21-set-clear
branch
from
dfed3d4
to
df88184
Compare
liggitt
reviewed
Aug 16, 2023
set/set.go
Outdated
| for key := range s { | ||
| delete(s, key) | ||
| } | ||
| clear(s) |
There was a problem hiding this comment.
If you make two files for this function, one pre-go1.21 and one go1.21+, this could merge sooner
There was a problem hiding this comment.
Yup, the same thought occurred to me ;-).
skitt
force-pushed
the
golang-1.21-set-clear
branch
from
df88184
to
211c090
Compare
k8s-ci-robot
added
size/M
skitt
force-pushed
the
golang-1.21-set-clear
branch
from
211c090
to
167c46a
Compare
skitt
changed the title
|
@liggitt any chance for a re-review? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold mind squashing this to a single commit? |
k8s-ci-robot
added
the
do-not-merge/hold
This addresses the edge cases where a set couldn't be fully cleared, and will be more efficient in cases where the loop isn't optimised away. To allow this to be tested in CI, configure tests with Go 1.20 and 1.21 (since 1.21 has been released, 1.19 has reached EOL). Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
golang-1.21-set-clear
branch
from
167c46a
to
571d869
Compare
k8s-ci-robot
removed
the
lgtm
Done! |
|
/hold cancel |
k8s-ci-robot
added
lgtm
|
/assign @thockin |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, skitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The main motivation behind this PR is to be able to use the
clear()function added in Go 1.21 to clear sets.The PR also enables Go 1.21 in CI and drops 1.19 which is EOL.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: