Ensure set.Equal() compares the two set lengths #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set.Equal() currently checks the length of the owning set against itself, so a.Equal(b) returns true if a is a superset of b, with no further restriction. This fixes the length check and adds unit tests to catch this case. Signed-off-by: Stephen Kitt <skitt@redhat.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/kind bug |
2 tasks
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
skitt
added a commit
to skitt/admiral
that referenced
this pull request
Jul 11, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/cloud-prepare
that referenced
this pull request
Jul 11, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner
that referenced
this pull request
Jul 11, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/subctl
that referenced
this pull request
Jul 11, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/lighthouse
that referenced
this pull request
Jul 11, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this pull request
Jul 11, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
mkolesnik
pushed a commit
to submariner-io/cloud-prepare
that referenced
this pull request
Jul 12, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
tpantelis
pushed a commit
to submariner-io/admiral
that referenced
this pull request
Jul 13, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
tpantelis
pushed a commit
to submariner-io/lighthouse
that referenced
this pull request
Jul 13, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
tpantelis
pushed a commit
to submariner-io/subctl
that referenced
this pull request
Jul 13, 2023
See kubernetes/utils#286 for details. Signed-off-by: Stephen Kitt <skitt@redhat.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
set.Equal() currently checks the length of the owning set against itself, so a.Equal(b) returns true if a is a superset of b, with no further restriction.
This fixes the length check and adds unit tests to catch this case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: