Fix panic calling stop before run #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
thockin
approved these changes
Nov 29, 2017
apelisse
reviewed
Nov 29, 2017
| @@ -133,15 +133,17 @@ func (cmd *cmdWrapper) Output() ([]byte, error) { | |||
| // Stop is part of the Cmd interface. | |||
There was a problem hiding this comment.
I think that comment should explain what happens if it's called before Run() (and probably more). IOW, We should know what to expect from that function without having to read the code, since godoc shows you the comments without the code.
There was a problem hiding this comment.
https://godoc.org/k8s.io/utils/exec#Cmd
Actually, you might want to change the Cmd interface documentation, since this object is hidden/private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.