Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some area/github-* labels for kubernetes/org #9738

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 8, 2018

Would like to add these to the kubernetes/org issue templates to
auto-label incoming requests

/cc @fejta @cblecker

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync labels Oct 8, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 8, 2018

pull-test-infra-verify-labels — Job failed.

You know, I'm really glad I wrote this check, because I'm the jerk who keeps running into it.

Would like to add these to the kubernetes/org issue templates to
auto-label incoming requests
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2018
@cblecker
Copy link
Member

cblecker commented Oct 9, 2018

/lgtm
/hold

🚀

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Oct 9, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 9, 2018

/retest

@spiffxp
Copy link
Member Author

spiffxp commented Oct 9, 2018

Will likely need to rebase on top of #9747 when it merges

@krzyzacy
Copy link
Member

krzyzacy commented Oct 9, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit f4498d9 into kubernetes:master Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the label-config configmap using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Would like to add these to the kubernetes/org issue templates to
auto-label incoming requests

/cc @fejta @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the k-org-area-labels branch October 10, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync area/prow/deck Issues or PRs related to prow's deck component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants