Skip to content

autoscaler: Remove test-and-verify #35833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

autoscaler: Remove test-and-verify #35833

wants to merge 1 commit into from

Conversation

@adrianmoisey
Copy link
Member

@adrianmoisey adrianmoisey commented Nov 1, 2025

Add unit tests, golangci-lint and verify

Relates to the changes made in

@adrianmoisey
Remove test-and-verify
5d3fff2 
Add unit tests, golangci-lint and verify
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrianmoisey
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder changed the title Remove test-and-verify autoscaler: Remove test-and-verify Nov 3, 2025
@jackfrancis
Copy link
Contributor

jackfrancis commented Nov 4, 2025

#35848 replaces this one as @adrianmoisey, @omerap12 and I discussed offline the new names

Thank you @adrianmoisey!

@jackfrancis
Copy link
Contributor

jackfrancis commented Nov 4, 2025

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

@jackfrancis: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

@rjsadow rjsadow Awaiting requested review from rjsadow

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

No one assigned

Labels

area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianmoisey @k8s-ci-robot @jackfrancis