Stop requesting reviewers for kubernetes-sigs/headlamp repo

[illume]

The bot is overloading our contributors github notifications.
For many PRs all of our reviewers are added.

cc @joaquimrocha

[k8s-ci-robot]

Welcome @illume!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: illume
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @illume. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[BenTheElder]

The bot is overloading our contributors github notifications.
For many PRs all of our reviewers are added.

Do you have an example? The bot will only pick two reviewers.

I looked at a random subset of open PRs, all had two reviewers.

As mentioned in the prow issue, the OWNERS files configure who is assigned for reviews, and who can do approvals.

If more people do a review, they will show up in the list. If someone manually comments /cc @person @other-person they will show up in the lost.

But the automatic reviewer suggestion should only be picking two from the pool based on the files touched in the PR and the OWNERS for those files (which can be in nested directories or at the root)

---

@kubernetes/sig-contributor-experience-leads to review/approve

[petr-muller]

As a k-s/prow maintainer I initially wanted to respond on kubernetes-sigs/prow#531 but here seems to be a better place. Besides what Ben said, generally links to specific cases with bad behavior would be helpful (examples of "PRs all of our reviewers are added").

Looking at kubernetes-sigs/headlamp#4055

Not if they know that part of the codebase well

That's a use case for granular OWNERS files - if there are directories where only certain people should be assigned, I'd encourage you to configure OWNERS files that way.

Not if they are on vacation, or are busy with other tasks

k8s Prow configures use_status_availability: true; blunderbuss should respect GH "busy" status if people use it

It has no understanding of draft PRs, and pings two people even if people purposely put PRs into draft mode because they don't want to ping maintainers.

Guilty as charged on this one, that's a bug, tracked in kubernetes-sigs/prow#182 . Hopefully we can get it fixed - your

"It adds two at random, and then up to two more each time the PR changes state (like in and out of draft mode)."

Also suggests that we may have more bugs there? max_request_count: 2 should be respected, I would not expect more reviewers to be added on moving in/out the draft mode. Your sentence also suggests that there may be more events that cause excessive reviewers to be added. Examples of that would be helpful.

We can try and disable it until it's fixed

Besides the draft state, would you have more suggestions about what could be fixed? If so then I'm happy to hear them.

[petr-muller]

Heh, so:

https://github.com/kubernetes-sigs/prow/blob/0e4d5be4200d218ec8176958893aa82eb68a559e/pkg/plugins/config.go#L180-L182

@BenTheElder maybe k8s Prow would want to enable this?