Skip to content

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Oct 14, 2025

/hold

Requires kubernetes/kops#17671 to be merged first

Closes #35699

A concurrency limit is in place while the boskos-pool is growing; it will then be limited to 4.

/cc @alaypatel07 @BenTheElder @hakman

Also, ci-kubernetes-e2e-kops-gce-100-node-dra-with-workload-ipalias-using-cl2 will replace ci-kubernetes-e2e-gce-100-node-dra-extended-resources-with-workload once it's green.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Oct 14, 2025
base_ref: master
path_alias: k8s.io/kubernetes
- org: alaypatel07
- org: kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please drop this, its intended to use my branch until we have merged this: kubernetes/perf-tests#3629

- org: kubernetes
repo: perf-tests
base_ref: dra-extended-resources
base_ref: master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please drop this, its intended to use my branch until we have merged this: kubernetes/perf-tests#3629

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

value: "true"
- name: PROMETHEUS_PVC_STORAGE_CLASS
value: "ssd-csi"
- name: CLOUD_PROVIDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DRA test also require enabling certain feature flags. From the config above this is set:

            - --env=KUBE_FEATURE_GATES=DynamicResourceAllocation=true

In the case of kops, should we be setting the KOPS_FEATURE_FLAGS feature flag with above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRA feature should be autoenabled already. kops does enable all GA/Beta flags by default

@upodroid
Copy link
Member Author

This is ready to be merged. I'll cancel the hold once the kops PR is merged.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@BenTheElder
Copy link
Member

It might make sense to move forward with a kube-up based job in the short term, the kops PR has been ongoing for a few weeks now?

@alaypatel07
Copy link
Contributor

It might make sense to move forward with a kube-up based job in the short term, the kops PR has been ongoing for a few weeks now?

+1, I would really like to push forward with a 5k node dra test, considering it GA'ed last release and we don't have any scale test is little concerning to me.

@upodroid
Copy link
Member Author

upodroid commented Oct 28, 2025

I'll merge the other PR by the end of the week if the kops one is still held up

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@upodroid
Copy link
Member Author

This is ready to be merged

@alaypatel07
Copy link
Contributor

Let's merge, I'll keep an eye on results

@alaypatel07
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2025
@alaypatel07
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit e0a8788 into kubernetes:master Oct 29, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key sig-scalability-periodic-dra.yaml using file config/jobs/kubernetes/sig-scalability/DRA/sig-scalability-periodic-dra.yaml
    • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
    • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml
  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml

In response to this:

/hold

Requires kubernetes/kops#17671 to be merged first

Closes #35699

A concurrency limit is in place while the boskos-pool is growing; it will then be limited to 4.

/cc @alaypatel07 @BenTheElder @hakman

Also, ci-kubernetes-e2e-kops-gce-100-node-dra-with-workload-ipalias-using-cl2 will replace ci-kubernetes-e2e-gce-100-node-dra-extended-resources-with-workload once it's green.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

4 participants