cleanup the GA feature from the sig-node test jobs #35214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/provider/gcp
HirazawaUi
force-pushed
the
clean-ga-feature
branch
from
26911bd to
223c625
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/assign @SergeyKanzhelev |
k8s-ci-robot
added
the
lgtm
|
@cheftako for approve |
k8s-ci-robot
added
the
needs-rebase
|
I think part of it was taken care of by a separate PR. Please rebase |
SergeyKanzhelev
moved this from Triage
to PRs Waiting on Author
in SIG Node CI/Test Board
HirazawaUi
force-pushed
the
clean-ga-feature
branch
from
223c625 to
6cd03ad
Compare
k8s-ci-robot
removed
lgtm
Rebased. |
k8s-ci-robot
added
the
lgtm
|
/assign @cheftako Could you approve this? |
|
@BenTheElder can you please help with merging this? This is just a clean up |
k8s-ci-robot
added
the
needs-rebase
HirazawaUi
force-pushed
the
clean-ga-feature
branch
from
6cd03ad to
b785314
Compare
k8s-ci-robot
removed
lgtm
|
ping @BenTheElder – would you mind taking a look at this? Just some light cleanup. |
pacoxu
approved these changes
Aug 19, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HirazawaUi, pacoxu, SergeyKanzhelev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only cleans up the PodLifecycleSleepActionAllowZero and PodLifecycleSleepAction features.
The SidecarContainers feature has also reached GA, but in the k/k repo's e2e tests, the test cases related to this feature are still wrapped with the SidecarContainers label. Therefore, we may need to first remove this label from the e2e test files in the k/k repo.