-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Azure scale: Disable host-level API availability checks #35109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure scale: Disable host-level API availability checks #35109
Conversation
1e15402
to
59c99cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nojnhuh: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Azure clusters built for SIG-Scalability tests don't expose each control plane node behind a different address, only a shared public load balancer with a single IP and port. The host-level checks that are enabled by default for the APIAvailabilty CL2 test are thus failing and adding lots of noise to logs. This change disables those checks in favor of the cluster-wide one.
These changes are based on this snippet of the CL2 config:
https://github.com/kubernetes/perf-tests/blob/690e2e8bcf598bba7d773c85dc3f871719198f90/clusterloader2/testing/load/modules/measurements.yaml#L135-L147
And here where those values are used:
https://github.com/kubernetes/perf-tests/blob/690e2e8bcf598bba7d773c85dc3f871719198f90/clusterloader2/pkg/measurement/common/api_availability_measurement.go#L204
Initially these changes are only made to the presubmit jobs. Once we determine they do what we expect, we'll promote them to the periodic jobs.
/assign @jackfrancis