Skip to content

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 10, 2025

The Azure clusters built for SIG-Scalability tests don't expose each control plane node behind a different address, only a shared public load balancer with a single IP and port. The host-level checks that are enabled by default for the APIAvailabilty CL2 test are thus failing and adding lots of noise to logs. This change disables those checks in favor of the cluster-wide one.

These changes are based on this snippet of the CL2 config:
https://github.com/kubernetes/perf-tests/blob/690e2e8bcf598bba7d773c85dc3f871719198f90/clusterloader2/testing/load/modules/measurements.yaml#L135-L147

And here where those values are used:
https://github.com/kubernetes/perf-tests/blob/690e2e8bcf598bba7d773c85dc3f871719198f90/clusterloader2/pkg/measurement/common/api_availability_measurement.go#L204

Initially these changes are only made to the presubmit jobs. Once we determine they do what we expect, we'll promote them to the periodic jobs.

/assign @jackfrancis

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider labels Jul 10, 2025
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jul 10, 2025
@pohly pohly moved this from 🆕 New to ✅ Done in Dynamic Resource Allocation Jul 15, 2025
@pohly pohly moved this from ✅ Done to 👀 In review in Dynamic Resource Allocation Jul 15, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
@nojnhuh nojnhuh force-pushed the azure-scale-pre-internal-ips branch from 1e15402 to 59c99cd Compare August 8, 2025 19:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2025
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4ce8908 into kubernetes:master Aug 8, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
  • key sig-scalability-presubmit-dra-capz.yaml using file config/jobs/kubernetes/sig-scalability/DRA/sig-scalability-presubmit-dra-capz.yaml

In response to this:

The Azure clusters built for SIG-Scalability tests don't expose each control plane node behind a different address, only a shared public load balancer with a single IP and port. The host-level checks that are enabled by default for the APIAvailabilty CL2 test are thus failing and adding lots of noise to logs. This change disables those checks in favor of the cluster-wide one.

These changes are based on this snippet of the CL2 config:
https://github.com/kubernetes/perf-tests/blob/690e2e8bcf598bba7d773c85dc3f871719198f90/clusterloader2/testing/load/modules/measurements.yaml#L135-L147

And here where those values are used:
https://github.com/kubernetes/perf-tests/blob/690e2e8bcf598bba7d773c85dc3f871719198f90/clusterloader2/pkg/measurement/common/api_availability_measurement.go#L204

Initially these changes are only made to the presubmit jobs. Once we determine they do what we expect, we'll promote them to the periodic jobs.

/assign @jackfrancis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants