Skip to content

etcd: enable pull-etcd-govulncheck for release-3.5 branch #35050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abdurrehman107
Copy link
Member

This PR enables pull-etcd-govulncheck for release-3.5.

ref: #32754

cc @ivanvc @joshjms

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from jmhbnz and serathius June 27, 2025 10:10
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 27, 2025
@joshjms
Copy link
Member

joshjms commented Jun 27, 2025

govulncheck also has a postsubmit, would it be better to do it in this PR or another? @ivanvc

@abdurrehman107
Copy link
Member Author

I think we should take care of it here. I'll add it.

Signed-off-by: Abdur Rehman <razashahid107@gmail.com>
@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman-20250627/pull-etcd-govuluncheck branch from 149865e to b9f774c Compare June 27, 2025 15:13
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks, @abdurrehman107.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abdurrehman107, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2a85798 into kubernetes:master Jun 27, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@abdurrehman107: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-postsubmits.yaml using file config/jobs/etcd/etcd-postsubmits.yaml
  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

This PR enables pull-etcd-govulncheck for release-3.5.

ref: #32754

cc @ivanvc @joshjms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants