Skip to content

kubeadm: add 1.32 jobs remove 1.28 #33892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 2, 2024
Merged

kubeadm: add 1.32 jobs remove 1.28 #33892

k8s-ci-robot merged 1 commit into from
Dec 2, 2024

Conversation

@neolit123
Copy link
Member

@neolit123 neolit123 commented Dec 2, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 2, 2024
This was referenced Dec 2, 2024
Merged
Closed
Closed
@neolit123
Copy link
Member Author

neolit123 commented Dec 2, 2024

/cc @kannon92

@k8s-ci-robot k8s-ci-robot requested a review from kannon92 December 2, 2024 20:08
@neolit123 neolit123 changed the title kubeadm: add 1.32 jobs drop 1.28 kubeadm: add 1.32 jobs remove 1.28 Dec 2, 2024
cpanato
cpanato approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 85c84ff into kubernetes:master Dec 2, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

@neolit123: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-discovery.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-discovery.yaml
  • key kubeadm-kinder-dryrun.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-dryrun.yaml
  • key kubeadm-kinder-external-ca.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-ca.yaml
  • key kubeadm-kinder-external-etcd.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-etcd.yaml
  • key kubeadm-kinder-kubelet-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-kubelet-x-on-y.yaml
  • key kubeadm-kinder-upgrade.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-upgrade.yaml
  • key kubeadm-kinder-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-x-on-y.yaml
  • key kubeadm-kinder.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neolit123
Copy link
Member Author

neolit123 commented Dec 2, 2024

@cpanato this needs LGTM too or it will error

@pacoxu pacoxu mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

@kannon92 kannon92 Awaiting requested review from kannon92

1 more reviewer

@cpanato cpanato cpanato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neolit123 @k8s-ci-robot @cpanato