-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: remove unused secrets for capv and add janitor user #32688
config: remove unused secrets for capv and add janitor user #32688
Conversation
/assign @fabriziopandini @sbueringer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/lgtm |
/lgtm @chrischdi please update the PR title |
/lgtm |
config/prow/cluster/build/build_kubernetes-external-secrets_customresource.yaml
Outdated
Show resolved
Hide resolved
2ff8a74
to
1575eba
Compare
/lgtm |
/assign @ameukam Context: we are cleaning up our VMC environment so it already works the same way as the new env. This should speed up the migration, more context: |
/approve Remove the hold when ready. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thx! /hold cancel @ameukam I don't remember. Is this getting deployed automatically, or do we have to ping someone? |
We will see this in the audit logs of the secrets :-) |
Would be still interesting to know, as it also might tell us who to ping :) |
According the secret logs: the new ones get requested, the old ones stopped getting requested since 10:51 CEST, which matches ~ when this PR merged. |
Follow up to:
Related to: