Add node e2e version printer for docker validation test. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| publishers: | ||
| - groovy-postbuild: | ||
| script: | | ||
| def imageMatcher = manager.getLogMatcher("GCE_IMAGE=(.*)") |
There was a problem hiding this comment.
Your log shows GCE_IMAGES=gci-test-54-8618-0-0 - notice the S.
There was a problem hiding this comment.
Sorry, I didn't post the first few lines:
++ GCI_IMAGE_PROJECT=container-vm-image-staging
++ GCI_IMAGE_FAMILY=gci-canary-test
+++ gcloud compute images describe-from-family gci-canary-test --project=container-vm-image-staging '--format=value(name)'
++ GCI_IMAGE=gci-test-54-8618-0-0 <-------------- Here
+++ curl -fsSL --retry 3 https://api.github.com/repos/docker/docker/releases
+++ tac
+++ grep -m 1 '"tag_name"\:'
+++ grep -Eo '[0-9\.rc-]+'
+++ tac
++ DOCKER_VERSION=1.12.0-rc4
++ GCI_CLOUD_INIT=test/e2e_node/jenkins/gci-init.yaml
++ GCE_HOSTS=
++ GCE_IMAGES=gci-test-54-8618-0-0
++ GCE_IMAGE_PROJECT=container-vm-image-staging
++ GCE_ZONE=us-central1-f
++ GCE_PROJECT=google.com:noogler-kubernetes
++ GCE_INSTANCE_METADATA='user-data<test/e2e_node/jenkins/gci-init.yaml,gci-docker-version=1.12.0-rc4'
++ CLEANUP=true
++ GINKGO_FLAGS=--skip=FLAKY
++ SETUP_NODE=true
There was a problem hiding this comment.
Then it should be GCI_IMAGE=, as opposed to GCE_IMAGE=, right?
There was a problem hiding this comment.
Yeah, my bad. Good catch!
Random-Liu
force-pushed
the
add-node-e2e-version-printer
branch
from
42b138f
to
28beeae
Compare
wonderfly
added
the
lgtm
16 tasks
mborsz
pushed a commit
to mborsz/test-infra
that referenced
this pull request
Dec 14, 2018
ClusterLoader - Moving errors to pkg/errors
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
Automatic merge from submit-queue prow: correct periodics config Fixes istio/test-infra#303 ```release-note NONE ```
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log printed by node e2e docker validation test is like this:
This PR added a version printer to print
DOCKER_VERSIONandGCI_IMAGE.@wonderfly Could you take a look? Thanks a lot! :)