Skip to content

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Jun 8, 2023

Add retaining lgtm through squash to the Cluster API Operator repo.

Part of: kubernetes-sigs/cluster-api-operator#153

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 8, 2023
@furkatgofurov7
Copy link
Member Author

@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: GitHub didn't allow me to request PR reviews from the following users: damdo.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @alexander-demicev @JoelSpeed @damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furkatgofurov7
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 8, 2023 12:55
@dims
Copy link
Member

dims commented Jun 8, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev, dims, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furkatgofurov7
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1d03d5e into kubernetes:master Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Add retaining lgtm through squash to the Cluster API Operator repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants