Skip to content

Using 1.24 variant of kubekins image #27336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ipochi
Copy link
Contributor

@ipochi ipochi commented Sep 1, 2022

Switching the repo and the job to go v1.18, hence the variant change to
1.24 which uses go v1.18.5

Signed-off-by: Imran Pochi imran@kinvolk.io

Switching the repo and the job to go v1.18, hence the variant change to
1.24 which uses go v1.18.5

Signed-off-by: Imran Pochi <imran@kinvolk.io>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 1, 2022
@ipochi
Copy link
Contributor Author

ipochi commented Sep 1, 2022

@cheftako

The lint job keeps failing because the 1.23 variant of the image uses go v1.17.13 whereas since we are moving forward with go v1.18., the 1.24 variant has the correct go version.

kubernetes-sigs/apiserver-network-proxy#381

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_apiserver-network-proxy/381/pull-apiserver-network-proxy-make-lint/1565277798803705856

@matthyx
Copy link
Contributor

matthyx commented Sep 1, 2022

/lgtm
/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2022
@alvaroaleman alvaroaleman removed their assignment Sep 1, 2022
@dims
Copy link
Member

dims commented Sep 1, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ipochi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit ed307a9 into kubernetes:master Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

@ipochi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key apiserver-network-proxy-presubmits.yaml using file config/jobs/kubernetes-sigs/apiserver-network-proxy/apiserver-network-proxy-presubmits.yaml

In response to this:

Switching the repo and the job to go v1.18, hence the variant change to
1.24 which uses go v1.18.5

Signed-off-by: Imran Pochi imran@kinvolk.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants