Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed special-resource-operator --> kernel-module-management. #27012

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Aug 3, 2022

Also removed some outdated tests and bumped golang version to 1.18

Signed-off-by: Yoni Bettan yonibettan@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ybettan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ybettan
Copy link
Contributor Author

ybettan commented Aug 3, 2022

FYI @qbarrand

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2022
@ybettan
Copy link
Contributor Author

ybettan commented Aug 3, 2022

@mrunalp Can we please have you review here and the ok-to-test label?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/testgrid sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2022
@ybettan ybettan changed the title Changing the dir for the ci tests of KMMO. Renamed special-resource-operator --> kernel-module-management. Aug 7, 2022
@ybettan
Copy link
Contributor Author

ybettan commented Aug 7, 2022

Relates to issue kubernetes/org#3587

@dims
Copy link
Member

dims commented Aug 7, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2022
Also removed some outdated tests and bumped golang version to 1.18

Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
@ybettan
Copy link
Contributor Author

ybettan commented Aug 9, 2022

@dims Is there anything needed that is preventing us from lgtm?

@dims
Copy link
Member

dims commented Aug 9, 2022

/approve
/lgtm

@ybettan in the future, you can ping the folks listed in the OWNERS file where you updated a file(s). For example here, you would ping:

- adrianchiris
- zvonkok
- mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6af79a3 into kubernetes:master Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

@ybettan: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kernel-module-management-presubmits.yaml using file config/jobs/kubernetes-sigs/kernel-module-management/kernel-module-management-presubmits.yaml
  • key special-resource-operator-presubmits.yaml using file ``

In response to this:

Also removed some outdated tests and bumped golang version to 1.18

Signed-off-by: Yoni Bettan yonibettan@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ybettan
Copy link
Contributor Author

ybettan commented Aug 9, 2022

TY @dims .
Will ping the correct people next time. Sorry for the noise.

@ybettan ybettan deleted the ci branch August 11, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants