Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP-3203] Prow job to Push CVE feed to GCS bucket #26896

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

nehaLohia27
Copy link
Contributor

Signed-off-by: Neha Lohia nehapithadiya444@gmail.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 22, 2022
@nehaLohia27
Copy link
Contributor Author

cc @PushkarJ

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/testgrid sig/security Categorizes an issue or PR as relevant to SIG Security. labels Jul 22, 2022
hack/fetch-cve-feed.sh Outdated Show resolved Hide resolved
@ameukam
Copy link
Member

ameukam commented Jul 25, 2022

@PushkarJ @nehaLohia27 is there a specific reason why we can't keep the script in https://github.com/kubernetes/sig-security ? IMHO the sig repo is a better fit than the test-infra repo.

@PushkarJ
Copy link
Member

@PushkarJ @nehaLohia27 is there a specific reason why we can't keep the script in https://github.com/kubernetes/sig-security ? IMHO the sig repo is a better fit than the test-infra repo.

I would be open to that but can you help us suggest a way that would allow passing the shell script and python script from k/sig-security as a command here: https://github.com/kubernetes/test-infra/pull/26896/files#diff-474569c4879b531076d568cdde6ff0a7196122ade414daf4ba92408a88de5d48R109-R110

@PushkarJ
Copy link
Member

/hold
/retitle [KEP-3203] Prow job to generate CVE feed and push to GCS bucket

(Holding until GCS bucket is created kubernetes/k8s.io#3494)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot changed the title WIP: create prow job to generate the cve json feed KEP 3203 [KEP-3203] Prow job to generate CVE feed and push to GCS bucket Jul 25, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2022
@nehaLohia27
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
@PushkarJ
Copy link
Member

/retitle [KEP-3203] Prow job to Push CVE feed to GCS bucket
/lgtm
/hold

(These two need to be completed before merging this PR: kubernetes/sig-security#55 and kubernetes/k8s.io#3494)

@k8s-ci-robot k8s-ci-robot changed the title [KEP-3203] Prow job to generate CVE feed and push to GCS bucket [KEP-3203] Prow job to Push CVE feed to GCS bucket Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@ameukam
Copy link
Member

ameukam commented Jul 29, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, nehaLohia27

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
@PushkarJ
Copy link
Member

PushkarJ commented Aug 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@PushkarJ
Copy link
Member

PushkarJ commented Aug 1, 2022

/hold cancel

(kubernetes/sig-security#55 and kubernetes/k8s.io#3494 is done)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1b10b1f into kubernetes:master Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

@nehaLohia27: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-security-trusted.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-security-trusted.yaml

In response to this:

Signed-off-by: Neha Lohia nehapithadiya444@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants