add main branch for presubmit jobs and update some generate scripts #24734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/provider/gcp
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
force-pushed
the
kep-2853-initia-workl
branch
from
cc30712 to
6646e6c
Compare
cpanato
commented
Dec 23, 2021
| @@ -60,7 +61,8 @@ for release in "$@"; do | |||
| containerd_api_model="https://raw.githubusercontent.com/kubernetes-sigs/windows-testing/master/job-templates/kubernetes_containerd_1_23.json" | |||
| ;; | |||
| *) | |||
| branch="master" | |||
| branch=$(echo -e 'master # TODO(releng): Remove once repo default branch has been renamed\n - main') | |||
There was a problem hiding this comment.
did not run the generate for this because it created and removed some jobs and I'm not sure if that is ok
|
/approve |
k8s-ci-robot
added
the
approved
ehashman
reviewed
Jan 6, 2022
| @@ -3,7 +3,9 @@ presubmits: | |||
| - name: pull-kubernetes-node-e2e | |||
| cluster: k8s-infra-prow-build | |||
| branches: | |||
| - master | |||
|
gently ping @justaugustus |
justaugustus
approved these changes
Jan 7, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cpanato: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work that we are doing for this KEP kubernetes/enhancements#3053
mainin the job configs for the presubmits/assign @justaugustus @saschagrunert @puerco @dims @BenTheElder
cc @kubernetes/release-engineering