Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: remove unused images #23617

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 15, 2021

Related:

Determined as part of a survey of gcr.io/k8s-testimages and cs.k8s.io that neither of these images are used

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 15, 2021

/cc @BenTheElder @ameukam @dims

@ameukam
Copy link
Member

ameukam commented Sep 15, 2021

/lgtm
/hold
Possible impact on contributors outside of the k8s community ?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 15, 2021

I'll send an announcement to kubernetes-sig-testing and kubernetes-dev for these, stating that they'll no longer be updated

AFAICT everything showing up in github search is from forks of test-infra, or old forks of kubernetes/kubernetes that still have bazel files

@dims
Copy link
Member

dims commented Sep 15, 2021

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Sep 15, 2021

/hold cancel
Announcement: https://groups.google.com/g/kubernetes-dev/c/PhirMQ9KIo0

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit e4731a9 into kubernetes:master Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Related:

Determined as part of a survey of gcr.io/k8s-testimages and cs.k8s.io that neither of these images are used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the rm-unused-images branch September 17, 2021 20:05
@spiffxp spiffxp mentioned this pull request Sep 17, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants