Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubetest: update README.md #23458

Merged
merged 1 commit into from
Sep 2, 2021
Merged

kubetest: update README.md #23458

merged 1 commit into from
Sep 2, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 2, 2021

Related:

This is mostly a change to trigger a new build of kubekins-e2e

/hold
Don't want this to merge until #23457 has

@spiffxp
kubetest: update README.md
e6b3c44 
This is mostly a change to trigger a new build of kubekins-e2e
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 2, 2021
@spiffxp spiffxp mentioned this pull request Sep 2, 2021
Open
77 tasks
@spiffxp
Copy link
Member Author

spiffxp commented Sep 2, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
orsenthil
orsenthil approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@k8s-ci-robot
Copy link
Contributor

@orsenthil: changing LGTM is restricted to collaborators

In response to this:

LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, orsenthil, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e4567b8 into kubernetes:master Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 2, 2021
@spiffxp spiffxp deleted the kubetest-is-deprecated branch September 3, 2021 10:42
@spiffxp spiffxp mentioned this pull request Sep 3, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Sep 9, 2021

One thing I am confused by here is why the kubekins images built by the canary job have a slightly longer git sha as part of their tag

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-kubekins-e2e/1433543709261041664

2021/09/02 21:42:36 Successfully built image: gcr.io/k8s-testimages/kubekins-e2e:v20210902-e4567b8-1.20 gcr.io/k8s-testimages/kubekins-e2e:latest-1.20

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-kubekins-e2e-canary/1433543709189738496

2021/09/02 21:41:25 Successfully built image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20210902-e4567b8e9c-1.19 gcr.io/k8s-staging-test-infra/kubekins-e2e:latest-1.19

The old job is e4567b8 or 7 char longs, the new job is e4567b8e9c or 10 chars long

@spiffxp
Copy link
Member Author

spiffxp commented Sep 9, 2021

Image builder uses the output of git show --tags --always --dirty which ends up being an abbreviated SHA if not on a tag.

My local copy of git (2.33.0), running the same command, gives a SHA of length 10 as well.

The jobs run in different images. It's likely the old image has a version of git older than 2.11.0, which is when a change landed that caused the default length of abbreviated SHAs to scale based on the repo size (ref: https://github.com/git/git/blob/master/Documentation/RelNotes/2.11.0.txt#L22-L26)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@orsenthil orsenthil orsenthil approved these changes

@amwat amwat Awaiting requested review from amwat

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubetest cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @k8s-ci-robot @orsenthil @cblecker