Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bump promoter jobs" #23151

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Revert "bump promoter jobs" #23151

merged 1 commit into from
Aug 5, 2021

Conversation

listx
Copy link
Contributor

@listx listx commented Aug 5, 2021

This reverts commit 61a7566.

Unfortunately I forgot to change the calling conventions because in the
meantime since the last update, (vs version v2.4.1), the promoter uses
slightly different flags.

See https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2476/pull-k8sio-cip/1423412661231554560 for a log (reproduced below):

Error: unknown shorthand flag: 't' in -thin-manifest-dir=/home/prow/go/src/github.com/kubernetes/k8s.io/k8s.gcr.io
Usage:
  cip [command]

Available Commands:
  audit       Run the image auditor
  completion  generate the autocompletion script for the specified shell
  help        Help about any command
  run         Promote images from a staging registry to production
  version     output version information

Flags:
      --dry-run            test run promotion without modifying any registry
  -h, --help               help for cip
      --log-level string   the logging verbosity, either 'panic', 'fatal', 'error', 'warning', 'info', 'debug', 'trace' (default "info")

Use "cip [command] --help" for more information about a command.

time="2021-08-05T22:38:03Z" level=fatal msg="unknown shorthand flag: 't' in -thin-manifest-dir=/home/prow/go/src/github.com/kubernetes/k8s.io/k8s.gcr.io"

This reverts commit 61a7566.

Unfortunately I forgot to change the calling conventions because in the
meantime since the last update, (vs version `v2.4.1`), the promoter uses
slightly different flags.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 5, 2021
@listx
Copy link
Contributor Author

listx commented Aug 5, 2021

/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2021
@justaugustus
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2021
@justaugustus
Copy link
Member

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, listx, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit caeaace into kubernetes:master Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

@listx: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key container-image-promoter.yaml using file config/jobs/kubernetes/sig-release/cip/container-image-promoter.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
  • key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

This reverts commit 61a7566.

Unfortunately I forgot to change the calling conventions because in the
meantime since the last update, (vs version v2.4.1), the promoter uses
slightly different flags.

See https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/2476/pull-k8sio-cip/1423412661231554560 for a log (reproduced below):

Error: unknown shorthand flag: 't' in -thin-manifest-dir=/home/prow/go/src/github.com/kubernetes/k8s.io/k8s.gcr.io
Usage:
 cip [command]

Available Commands:
 audit       Run the image auditor
 completion  generate the autocompletion script for the specified shell
 help        Help about any command
 run         Promote images from a staging registry to production
 version     output version information

Flags:
     --dry-run            test run promotion without modifying any registry
 -h, --help               help for cip
     --log-level string   the logging verbosity, either 'panic', 'fatal', 'error', 'warning', 'info', 'debug', 'trace' (default "info")

Use "cip [command] --help" for more information about a command.

time="2021-08-05T22:38:03Z" level=fatal msg="unknown shorthand flag: 't' in -thin-manifest-dir=/home/prow/go/src/github.com/kubernetes/k8s.io/k8s.gcr.io"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants