Prow pubsub: supports presubmit jobs #22777
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/prow/pubsub
|
/hold |
chaodaiG
force-pushed
the
pubsub-presubmit
branch
from
20cb3e3 to
e151d8e
Compare
chaodaiG
force-pushed
the
pubsub-presubmit
branch
2 times, most recently
from
dbfa072 to
8fba9dd
Compare
chaodaiG
force-pushed
the
pubsub-presubmit
branch
from
8fba9dd to
a1ce8f6
Compare
k8s-ci-robot
added
size/L
| logrus.WithError(err).Fatal("Error starting secrets agent.") | ||
| } | ||
| tokenGenerator = secretAgent.GetTokenGenerator(flagOptions.pushSecretFile) | ||
| gitClient, err := flagOptions.github.GitClient(secretAgent, flagOptions.dryRun) |
There was a problem hiding this comment.
Does this couple us to GitHub or does it work with Gerrit as well? We just need a git client so we should probably avoid coupling to GH.
There was a problem hiding this comment.
This client is for inrepoconfig, which is not supported in gerrit yet. We can change here once inrepoconfig is supported in gerrit
There was a problem hiding this comment.
That makes sense, but I'm more wondering how this behaves without GitHub credentials supplied. In subscriber.go@198 we try to use the git client independent of whether we are using GitHub or Gerrit. It seems strange to use a client for a different code review provider when know it won't work and that also seems like it will result in misleading error messages.
Looks like we never try to use the git client until after we've checked if InRepoConfig is enabled for the repo and flag validation should pass if no GitHub flags are supplied so I think this is ok.
/shrug
/hold cancel
k8s-ci-robot
added
the
lgtm
| logrus.WithError(err).Fatal("Error starting secrets agent.") | ||
| } | ||
| tokenGenerator = secretAgent.GetTokenGenerator(flagOptions.pushSecretFile) | ||
| gitClient, err := flagOptions.github.GitClient(secretAgent, flagOptions.dryRun) |
There was a problem hiding this comment.
That makes sense, but I'm more wondering how this behaves without GitHub credentials supplied. In subscriber.go@198 we try to use the git client independent of whether we are using GitHub or Gerrit. It seems strange to use a client for a different code review provider when know it won't work and that also seems like it will result in misleading error messages.
Looks like we never try to use the git client until after we've checked if InRepoConfig is enabled for the repo and flag validation should pass if no GitHub flags are supplied so I think this is ok.
/shrug
/hold cancel
k8s-ci-robot
added
¯\_(ツ)_/¯
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, cjwagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It has been obsolete since kubernetes#22777.
Part of #22764