Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: update wg-k8s-infra jobs #22366

Merged
merged 2 commits into from
Jun 2, 2021
Merged

jobs: update wg-k8s-infra jobs #22366

merged 2 commits into from
Jun 2, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 27, 2021

Two followup changes in one PR.

Followup to kubernetes/k8s.io#2104 which added audit/create-or-update-pr.sh:

  • Use audit/create-or-update-pr.sh instead of the embedded bash script

Followup to kubernetes/org#2741 which added more wg-k8s-infra GitHub teams:

  • Empower the following teams to rerun the following jobs:
    • wg-k8s-infra-leads: anything in wg-k8s-infra-trusted.yaml
    • k8s-infra-group-admins: ci-k8sio-groups, post-k8sio-groups
    • k8s-infra-gcp-auditors: ci-k8s-io-audit

I'm totally open to growing the pool of people who can re-run these beyond those who have privileges to run the same code / deploy the same changes manually. But start with that overlap for now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@ameukam
Copy link
Member

ameukam commented Jun 1, 2021

/lgtm
/hold
Remove hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 2, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit d6e4e3e into kubernetes:master Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key wg-k8s-infra-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-trusted.yaml

In response to this:

Two followup changes in one PR.

Followup to kubernetes/k8s.io#2104 which added audit/create-or-update-pr.sh:

  • Use audit/create-or-update-pr.sh instead of the embedded bash script

Followup to kubernetes/org#2741 which added more wg-k8s-infra GitHub teams:

  • Empower the following teams to rerun the following jobs:
  • wg-k8s-infra-leads: anything in wg-k8s-infra-trusted.yaml
  • k8s-infra-group-admins: ci-k8sio-groups, post-k8sio-groups
  • k8s-infra-gcp-auditors: ci-k8s-io-audit

I'm totally open to growing the pool of people who can re-run these beyond those who have privileges to run the same code / deploy the same changes manually. But start with that overlap for now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the ci-k8sio-audit-use-script branch June 2, 2021 19:27
@spiffxp
Copy link
Member Author

spiffxp commented Jun 2, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-k8sio-audit/1400114429428764672 is currently the latest run, still uses the embedded bash command

Waiting on next job run to confirm this all still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@thockin thockin Awaiting requested review from thockin

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam