Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-cri-containerd-node-e2e-benchmark should be checking out containerd/containerd #21646

Merged
merged 1 commit into from
Apr 3, 2021
Merged

ci-cri-containerd-node-e2e-benchmark should be checking out containerd/containerd #21646

merged 1 commit into from
Apr 3, 2021

Conversation

dims
Copy link
Member

@dims dims commented Apr 3, 2021

Missed a spot in #21641

Signed-off-by: Davanum Srinivas davanum@gmail.com

@dims
ci-cri-containerd-node-e2e-benchmark should be checking out container…
f4ee9fb 
…d/containerd

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2021
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Apr 3, 2021
@dims
Copy link
Member Author

dims commented Apr 3, 2021

/assign @hasheddan @SergeyKanzhelev @adisky @ehashman

@k8s-ci-robot k8s-ci-robot added area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 3, 2021
hasheddan
hasheddan approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle ci-cri-containerd-node-e2e-benchmark should be checking out containerd/containerd

/lgtm

@k8s-ci-robot k8s-ci-robot changed the title ci-cri-containerd-node-e2e-benchmark should be checking out contained/containerd ci-cri-containerd-node-e2e-benchmark should be checking out containerd/containerd Apr 3, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e736a72 into kubernetes:master Apr 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 3, 2021
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

Missed a spot in #21641

Signed-off-by: Davanum Srinivas davanum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@vpickard vpickard Awaiting requested review from vpickard

Assignees

@ehashman ehashman

@adisky adisky

@SergeyKanzhelev SergeyKanzhelev

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@dims @k8s-ci-robot @hasheddan @ehashman @adisky @SergeyKanzhelev