Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External manager: add a placeholder yaml and update instructions to make things clearer #21610

Merged
merged 1 commit into from
Apr 3, 2021
Merged

External manager: add a placeholder yaml and update instructions to make things clearer #21610

merged 1 commit into from
Apr 3, 2021

Conversation

chaodaiG
Copy link
Contributor

@chaodaiG chaodaiG commented Apr 1, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2021
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 1, 2021
@chaodaiG
Copy link
Contributor Author

chaodaiG commented Apr 1, 2021

The existing instructions don't seem to be very descriptive to users, as learned from @chewong offline
/cc @chewong

@chaodaiG chaodaiG mentioned this pull request Apr 2, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, chases2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6215035 into kubernetes:master Apr 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 3, 2021
@chaodaiG chaodaiG deleted the external-secret-seed branch April 4, 2021 14:33
@chaodaiG chaodaiG mentioned this pull request Apr 5, 2021
Merged
@spiffxp spiffxp mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 chases2 approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@chewong chewong Awaiting requested review from chewong

Assignees

@chases2 chases2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@chaodaiG @k8s-ci-robot @chases2