Skip to content

add e2e test jobs for sigs.k8s.io/cluster-api-provider-openstack #21069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

add e2e test jobs for sigs.k8s.io/cluster-api-provider-openstack #21069

merged 1 commit into from
Mar 1, 2021

Conversation

@sbueringer
Copy link
Member

Adds new cluster-api-provider-openstack jobs to get finally rid of our OpenLab tests.

The tests itself will be added in a separate PR in the cluster-api-provider-openstack repo

Notes:

  • only cosmetic changes to the existing jobs (I diffed it against other providers and cleaned it up a bit)
  • we have two new jobs which are both optional for PR merge and won't be triggered per default:
    • pull-cluster-api-provider-openstack-e2e-test: will execute our new e2e tests
    • pull-cluster-api-provider-openstack-make-conformance: analog to our existing OpenLab conformance test, installs a cluster and executes conformance tests

xref: kubernetes-sigs/cluster-api-provider-openstack#577

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 28, 2021
@sbueringer
Copy link
Member Author

/assign @jichenjc

@sbueringer sbueringer mentioned this pull request Feb 28, 2021
Merged
jichenjc
jichenjc reviewed Mar 1, 2021
View reviewed changes
...ubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml
spec:
containers:
- command:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20210226-c001921-master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, do we want to get a released version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they only have versions like this and a job which automatically updates the used image for all ProwJobs every week or so (I just copied the image)

@jichenjc
Copy link
Contributor

jichenjc commented Mar 1, 2021

@sbueringer do I need wait kubernetes-sigs/cluster-api-provider-openstack#759 merged or
merge this directly? Thanks

@jichenjc
Copy link
Contributor

jichenjc commented Mar 1, 2021

/lgtm

ok, I saw comments about the dependency, so we should merge this first

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit de8cab2 into kubernetes:master Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-openstack-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml

In response to this:

Adds new cluster-api-provider-openstack jobs to get finally rid of our OpenLab tests.

The tests itself will be added in a separate PR in the cluster-api-provider-openstack repo

Notes:

  • only cosmetic changes to the existing jobs (I diffed it against other providers and cleaned it up a bit)
  • we have two new jobs which are both optional for PR merge and won't be triggered per default:
  • pull-cluster-api-provider-openstack-e2e-test: will execute our new e2e tests
  • pull-cluster-api-provider-openstack-make-conformance: analog to our existing OpenLab conformance test, installs a cluster and executes conformance tests

xref: kubernetes-sigs/cluster-api-provider-openstack#577

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-add-capo-e2e-tests branch March 1, 2021 04:39
@sbueringer
Copy link
Member Author

/lgtm

ok, I saw comments about the dependency, so we should merge this first

Thx! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flaper87 flaper87 Awaiting requested review from flaper87

@Lion-Wei Lion-Wei Awaiting requested review from Lion-Wei

1 more reviewer

@jichenjc jichenjc jichenjc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jichenjc jichenjc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @jichenjc