Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto milestone kubernetes/org PRs #20664

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 29, 2021

I'm adding this in to get a better sense of how this commonly-used plugin will work after renaming the kubernetes/org default branch (ref: kubernetes/org#2466)

It might be nice to keep around for quick measure of PR's in this repo per kubernetes/kubernetes release lifecycle, but I can also see kicking it out since a lot of work in here is independent of that.

/cc @mrbobbytables @cblecker

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jan 29, 2021

/cc @mrbobbytables

@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit b9e03e1 into kubernetes:master Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

I'm adding this in to get a better sense of how this commonly-used plugin will work after renaming the kubernetes/org default branch (ref: kubernetes/org#2466)

It might be nice to keep around for quick measure of PR's in this repo per kubernetes/kubernetes release lifecycle, but I can also see kicking it out since a lot of work in here is independent of that.

/cc @mrbobbytables @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants