-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: Migrate image promotion jobs to k8s-infra-prow-build-trusted #19810
Conversation
We have another good run of I've also promoted vulndash to v0.3.0 in kubernetes/k8s.io#1385 and we can see the dry-run promotion postsubmit ( <snip>
I1102 23:10:35.755900 12 inventory.go:2107] Pending promotions:
I1102 23:10:35.755908 12 inventory.go:2109] {{gcr.io/k8s-staging-artifact-promoter true} {vulndash v0.3.0} sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693 {us.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com false} {vulndash v0.3.0}}
I1102 23:10:35.755918 12 inventory.go:2109] {{gcr.io/k8s-staging-artifact-promoter true} {vulndash v0.3.0} sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693 {asia.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com false} {vulndash v0.3.0}}
I1102 23:10:35.755936 12 inventory.go:2109] {{gcr.io/k8s-staging-artifact-promoter true} {vulndash v0.3.0} sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693 {eu.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com false} {vulndash v0.3.0}}
I1102 23:10:35.755986 12 inventory.go:1911] ---------- BEGIN PROMOTION (DRY RUN) ----------
I1102 23:10:35.756030 12 inventory.go:1659] Request <nil>: OK
I1102 23:10:35.756037 12 inventory.go:1659] Request <nil>: OK
I1102 23:10:35.756042 12 inventory.go:1659] Request <nil>: OK
captured reqs summary:
captured req: gcr.io/k8s-staging-artifact-promoter/vulndash -> asia.gcr.io/k8s-artifacts-prod/artifact-promoter/vulndash: Tag: 'v0.3.0' <ADD> sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693
captured req: gcr.io/k8s-staging-artifact-promoter/vulndash -> eu.gcr.io/k8s-artifacts-prod/artifact-promoter/vulndash: Tag: 'v0.3.0' <ADD> sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693
captured req: gcr.io/k8s-staging-artifact-promoter/vulndash -> us.gcr.io/k8s-artifacts-prod/artifact-promoter/vulndash: Tag: 'v0.3.0' <ADD> sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693
I1102 23:10:35.756107 12 cip.go:418] ********** FINISHED (DRY RUN) ********** |
(All of that to say, we can hold off for a few more runs, but I do believe this can safely be approved to officially migrate the jobs.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
/hold cancel |
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2e41085
to
1424e0c
Compare
(Needed to rebase out a conflict after #19811 merged.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, hasheddan, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justaugustus: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of kubernetes-sigs/promo-tools#269.
With some optimism in seeing
ci-k8sio-image-promo-canary
pass (job history), I'm opening this as a follow-up to #19789 to officially move image promotion jobs to K8s Infra.Signed-off-by: Stephen Augustus saugustus@vmware.com
/hold for a few more job runs, just to make sure. I'll also find an image to promote to test the postsubmit.
/assign @spiffxp @dims
cc: @listx @thockin @kubernetes/release-engineering