Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Migrate image promotion jobs to k8s-infra-prow-build-trusted #19810

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

justaugustus
Copy link
Member

Part of kubernetes-sigs/promo-tools#269.

With some optimism in seeing ci-k8sio-image-promo-canary pass (job history), I'm opening this as a follow-up to #19789 to officially move image promotion jobs to K8s Infra.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/hold for a few more job runs, just to make sure. I'll also find an image to promote to test the postsubmit.

/assign @spiffxp @dims
cc: @listx @thockin @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 2, 2020
@justaugustus
Copy link
Member Author

We have another good run of ci-k8sio-image-promo-canary: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-k8sio-image-promo-canary/1323388224453742592

I've also promoted vulndash to v0.3.0 in kubernetes/k8s.io#1385 and we can see the dry-run promotion postsubmit (post-k8sio-image-promo-canary) run successfully in https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-image-promo-canary/1323402077963030528:

<snip>
I1102 23:10:35.755900      12 inventory.go:2107] Pending promotions:
I1102 23:10:35.755908      12 inventory.go:2109]   {{gcr.io/k8s-staging-artifact-promoter   true} {vulndash v0.3.0} sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693 {us.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {vulndash v0.3.0}}
I1102 23:10:35.755918      12 inventory.go:2109]   {{gcr.io/k8s-staging-artifact-promoter   true} {vulndash v0.3.0} sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693 {asia.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {vulndash v0.3.0}}
I1102 23:10:35.755936      12 inventory.go:2109]   {{gcr.io/k8s-staging-artifact-promoter   true} {vulndash v0.3.0} sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693 {eu.gcr.io/k8s-artifacts-prod/artifact-promoter k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {vulndash v0.3.0}}
I1102 23:10:35.755986      12 inventory.go:1911] ---------- BEGIN PROMOTION (DRY RUN) ----------
I1102 23:10:35.756030      12 inventory.go:1659] Request <nil>: OK
I1102 23:10:35.756037      12 inventory.go:1659] Request <nil>: OK
I1102 23:10:35.756042      12 inventory.go:1659] Request <nil>: OK
captured reqs summary:
captured req: gcr.io/k8s-staging-artifact-promoter/vulndash -> asia.gcr.io/k8s-artifacts-prod/artifact-promoter/vulndash: Tag: 'v0.3.0' <ADD> sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693
captured req: gcr.io/k8s-staging-artifact-promoter/vulndash -> eu.gcr.io/k8s-artifacts-prod/artifact-promoter/vulndash: Tag: 'v0.3.0' <ADD> sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693
captured req: gcr.io/k8s-staging-artifact-promoter/vulndash -> us.gcr.io/k8s-artifacts-prod/artifact-promoter/vulndash: Tag: 'v0.3.0' <ADD> sha256:c015bfcc07326924927521709ea04cf19b7ab98ee16d97793a39a038b11a0693
I1102 23:10:35.756107      12 cip.go:418] ********** FINISHED (DRY RUN) **********

@justaugustus
Copy link
Member Author

(All of that to say, we can hold off for a few more runs, but I do believe this can safely be approved to officially migrate the jobs.)

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims
Copy link
Member

dims commented Nov 3, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@justaugustus
Copy link
Member Author

(Needed to rebase out a conflict after #19811 merged.)

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08ed247 into kubernetes:master Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 3, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
  • key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

Part of kubernetes-sigs/promo-tools#269.

With some optimism in seeing ci-k8sio-image-promo-canary pass (job history), I'm opening this as a follow-up to #19789 to officially move image promotion jobs to K8s Infra.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/hold for a few more job runs, just to make sure. I'll also find an image to promote to test the postsubmit.

/assign @spiffxp @dims
cc: @listx @thockin @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants