Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide jobs for e2e-node memory manager tests #19643

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Provide jobs for e2e-node memory manager tests #19643

merged 1 commit into from
Nov 6, 2020

Conversation

cynepco3hahue
Copy link

The tests can not run under the serial job because it will be
the alpha feature under the k8s 1.20.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

@k8s-ci-robot
Copy link
Contributor

Hi @cynepco3hahue. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 21, 2020
@matthyx
Copy link
Contributor

matthyx commented Oct 26, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2020
@matthyx
Copy link
Contributor

matthyx commented Oct 26, 2020

/assign @sjenning

@cynepco3hahue
Copy link
Author

@dims @sjenning Can you please review?

@MHBauer
Copy link
Contributor

MHBauer commented Nov 5, 2020

Where are the tests? A PR that has not merged yet?

@cynepco3hahue
Copy link
Author

@MHBauer Tests placed under the kubernetes/kubernetes#95479
In general, I can not guarantee that tests will work under the CI before I merge this PR and we will have a job that can be manually launched to check.

@dims
Copy link
Member

dims commented Nov 5, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cynepco3hahue, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@cynepco3hahue
Copy link
Author

/retest

@MHBauer
Copy link
Contributor

MHBauer commented Nov 5, 2020

I think this needs to add the dashboard definition to https://github.com/kubernetes/test-infra/blob/master/config/testgrids/kubernetes/sig-node/config.yaml

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@cynepco3hahue
Copy link
Author

I think this needs to add the dashboard definition to https://github.com/kubernetes/test-infra/blob/master/config/testgrids/kubernetes/sig-node/config.yaml

I do not need to add anything to this file according to https://github.com/kubernetes/test-infra/tree/master/config/testgrids#adding-a-prow-job-to-testgrid.
I added description annotation under memory manager jobs.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@cynepco3hahue
Copy link
Author

/retest

Provide jobs for e2e-node memory manager tests
c8618a6 
The tests can not run under the serial job because it will be
the alpha feature under the k8s 1.20.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@dims
Copy link
Member

dims commented Nov 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit b4aef1c into kubernetes:master Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

@cynepco3hahue: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

The tests can not run under the serial job because it will be
the alpha feature under the k8s 1.20.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Nov 10, 2020
Open
23 tasks
@cynepco3hahue cynepco3hahue mentioned this pull request Feb 9, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@vpickard vpickard Awaiting requested review from vpickard

Assignees

@dims dims

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
7 participants
@cynepco3hahue @k8s-ci-robot @matthyx @MHBauer @dims @fejta-bot @sjenning