Update plank dashboard to filter and group by more things #19007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow someone to filter and group by: - cluster - org - repo - state - type Add a third graph panel, and change each graph panel to group by user-selectable labels I intially had a graph panel for each of these, but: - it's a lot of clutter - it appeared to be timing out prometheus at the 90d range It turns out each template re-queries prometheus (serially) anytime the dashboard's time-range changes, and only after templates are refreshed do queries fired off for the dashboard's panels in parallel. This is necessary because the `label_values` prometheus query is time-range dependent. To mitigate this I changed the "type" and "state" templates to use a hardcoded list of values, since I think it unlikely we're going to add new prowjob types or states.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/config
|
Part of #18785 |
|
e.g. |
3 tasks
|
FYI @kubernetes/ci-signal |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow someone to filter and group by:
Add a third graph panel, and change each graph panel to group by
user-selectable labels
I intially had a graph panel for each of these, but:
It turns out each template re-queries prometheus (serially) anytime the
dashboard's time-range changes, and only after templates are refreshed do
queries fired off for the dashboard's panels in parallel. This is necessary
because the
label_valuesprometheus query is time-range dependent.To mitigate this I changed the "type" and "state" templates to use a hardcoded
list of values, since I think it unlikely we're going to add new prowjob types
or states.
This required #19004 to
merge first so I could use
template.custom