Limit KF Pipelines postsubmit tests to the master branch

[Ark-kun]

No description provided.

[k8s-ci-robot]

Hi @Ark-kun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ark-kun]

/assign @jlewi

[jlewi]

/lgtm
/approve
/hold
@Ark-kun Could you update the PR description with an explanation of why you don't want postsubmits running on branches?

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7c802bdc47830558b9ecf9ce78b90297f2ecc646

[Ark-kun]

why you don't want postsubmits running on branches?

Post-submit tests run after submission as opposed to pre-submit. After submission where? Usually it's the master branch. Otherwise the testis just presubmit test.
Am I missing something?

P.S. Our postsubmit tests rely on images build by CloudBuild which is only triggered by commits to the master branch.

[jlewi]

Why wouldn't you trigger postsubmits on the branch corresponding to the commit just like you do for presubmit?

For other repositories the main use case for branches is to cut release branches. e.g v0.6-branch.

Release branches will unavoidably get cherry-picks and other fixes. Those fixes should trigger pre/post and periodic tests which run against the code on the release branch.

[gaoning777]

I think we should run the postsubmit tests on all the branches and when features are added to the pipeline, create a branch in a forked repo.

[Ark-kun]

Why wouldn't you trigger postsubmits on the branch corresponding to the commit just like you do for presubmit?

Can you please help me understand the difference between presubmit and postsubmit tests?

[Ark-kun]

/cc @IronPan

[k8s-ci-robot]

@Ark-kun: GitHub didn't allow me to request PR reviews from the following users: IronPan.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @IronPan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlewi]

@Ark-kun presubmits are run on PRs. So in a presubmit you are running the tests on code before it is merged.

In a postsubmit you are trigger the tests on the commit resulting from a PR.

There are a couple reasons for doing this

1. The code in a PR branch might be based on an older commit then master. So the code in the PR is not an exact match for the postsubmit code. So as a result there can be some differences
2. On postsubmit its common to trigger longer more comprehensive tests then on presubmit to avoid slowing down development.

If you look at kubeflow/kubeflow
https://github.com/kubeflow/kubeflow/blob/master/prow_config.yaml

You can see that we trigger a more comprehensive suite of test on post submit.

[Ark-kun]

@jlewi

In a postsubmit you are trigger the tests on the commit resulting from a PR.

Expanding this:
In a postsubmit you trigger the tests on the commit resulting from merging the PR branch with the master branch.

Which implies that the commit for which the postsubmit test runs is a master branch (merge) commit.

[Ark-kun]

/cc @hongye-sun

[k8s-ci-robot]

@Ark-kun: GitHub didn't allow me to request PR reviews from the following users: hongye-sun.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hongye-sun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlewi]

Which implies that the commit for which the postsubmit test runs is a master branch (merge) commit.

Not if the PR is being merged into a branch.

So for most kubeflow repositories we cut release branches corresponding to every major release. During the lifetime of a major release fixes will get merged into the release branch. So we want postsubmits to be triggered on the branch which is not the master branch.

[jlewi]

/ok-to-test

@Ark-kun I don't have an oppionion on whether pipelines should be running its postsubmits on all branches or just master.

So if you want to submit this as is just go ahead and remove the hold.

It might be good if someone else from the pipelines toom could LGTM the decision not to run postsubmits on all branches.

[IronPan]

/lgtm
/approve

[k8s-ci-robot]

@IronPan: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubeflow/OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Bobgy]

Hi, just a side note, I think we discussed about using branches for releases instead for KFP. If we move to that structure, pushing fixes to release branches would need further postsubmit tests too. We can further configure this when that structure is ready.

[jlewi]

/hold cancel

[k8s-ci-robot]

@Ark-kun: Updated the job-config configmap in namespace default using the following files:

• key kubeflow-postsubmits.yaml using file config/jobs/kubeflow/kubeflow-postsubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.