-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
velodrome - upgrade py2 -> py3, #13164 #13383
Conversation
Hi @clarketm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, but please don't include merge commits in your PR branch. Instead rebase on the base branch to resolve conflicts.
@cjwagner - my mistake; I was following the steps on the UI. In hindsight, I should have simply resolved via rebase on command-line. The commit history should now be clean 👍 |
LGTM label has been added. Git tree hash: 5cfeb625b8ff6377e0f7a50d4c726f2a3a0ec6c7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, clarketm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the successor to #13368 and #13380 regarding the python2 -> python3 ( #13164 ) migration and targets the
velodrome
directory. Note that the rationale for preferringruamel.yaml
overpyYAML
is threefold:pyYAML
determines python version at install time whileruamel.yaml
does so at run time leveraging shimming and future imports.The combination of the above, along with the fact that
ruamel.yaml
is a fork ofpyYAML
and a direct superset of it (according to the current usage) is the justification for the change.