Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velodrome - upgrade py2 -> py3, #13164 #13383

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

clarketm
Copy link
Contributor

This is the successor to #13368 and #13380 regarding the python2 -> python3 ( #13164 ) migration and targets the velodrome directory. Note that the rationale for preferring ruamel.yaml over pyYAML is threefold:

  1. Although bazel obviously does support dual-python at the binary compilation level, it does not support dual dependency installation bazelbuild/rules_python.
  2. pyYAML determines python version at install time while ruamel.yaml does so at run time leveraging shimming and future imports.

The combination of the above, along with the fact that ruamel.yaml is a fork of pyYAML and a direct superset of it (according to the current usage) is the justification for the change.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @clarketm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/velodrome sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 10, 2019
@chases2
Copy link
Contributor

chases2 commented Jul 10, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2019
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but please don't include merge commits in your PR branch. Instead rebase on the base branch to resolve conflicts.

@clarketm
Copy link
Contributor Author

@cjwagner - my mistake; I was following the steps on the UI. In hindsight, I should have simply resolved via rebase on command-line. The commit history should now be clean 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5cfeb625b8ff6377e0f7a50d4c726f2a3a0ec6c7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, clarketm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9d0db7c into kubernetes:master Jul 10, 2019
@fejta fejta mentioned this pull request Aug 1, 2019
17 tasks
@clarketm clarketm deleted the velodrome branch August 24, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/velodrome cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants