-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable release-note automation on kubernetes-csi #12239
Conversation
All repos under kubernetes-csi should have release-note plugin enabled and require PRs to have ```release-note
0 files changed? |
3e24b3a
to
2935c84
Compare
Fixed :-) |
/lgtm |
LGTM label has been added. Git tree hash: 594e1ba62457e6e6f182d09f71a881c20e61bfd9
|
/assign @cjwagner |
/hold Going off of https://github.com/kubernetes/community/blob/master/sig-testing/charter.md#deploying-changes, this impacts only a single subproject and a single SIG, but because there are so many repos involved it would be a pain to roll back the sundry |
... I didn't really finish my charter thought. I know our charter doesn't state that there's a need for a written decision specifically, but:
ergo, asking for a written / documented decision |
I think the decision is up to the sig (storage in this case), but because of the number of repos impacted, I'd ask if we could have a notification cc'd to k-dev as an FYI. |
There is kubernetes-csi/docs#142. I am not sure it was discussed on any WG-CSI meeting, just on slack. I put it on Friday's agenda to get formal agreement of the proposal. |
@msau42 and I spoke with @spiffxp offline. We agree that kubernetes-CSI should be renamed from "workgroup" to "subproject". And we'll work to do that. In terms of this change, I approve on behalf of SIG-storage. This will require a release note for each new PR in the kubernetes-csi org. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, jsafrane, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saad-ali As I noted above, would you mind sending a note to k-dev as an FYI of the change before pulling the hold here? Thank you! |
@jsafrane: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All repos under kubernetes-csi should have release-note plugin enabled and require PRs to have
```release-note
.We want to use the same release-notes script as kubernetes/kubernetes to automate CHANGELOG creation. Most repos under kubernetes-csi already have appropriate PR template.
cc @msau42 @saad-ali @childsb from sig-storage side.