fix misspell build for go 1.13 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
size/XS
neolit123
changed the title
yastij
reviewed
Nov 7, 2019
| @@ -38,7 +38,7 @@ URL="https://github.com/client9/misspell" | |||
| echo "Cloning ${URL} in ${TMP_DIR}..." | |||
| git clone --quiet --depth=1 "${URL}" "${TMP_DIR}" | |||
| pushd "${TMP_DIR}" > /dev/null | |||
| go mod init | |||
| go mod init misspell | |||
There was a problem hiding this comment.
are we aligning with the go version of k/test-infra
There was a problem hiding this comment.
the version of go that is used in CI is the version in kubekins (test-infra) and that matches the version of k/k - 1.13.4.
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was overlooked for go 1.12 and broke when we started using 1.13.
/kind bug
/priority important-soon
/assign @yastij