add cgroup v1 warning as it is in maintaince mode for kube #38
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/node
pacoxu
force-pushed
the
cgroupv1-maintaince-mode
branch
from
8ff2876 to
9cecda3
Compare
neolit123
reviewed
Jul 24, 2024
validators/cgroup_validator_linux.go
Outdated
| requiredCgroupSpec = spec.CgroupsV2 | ||
| optionalCgroupSpec = spec.CgroupsV2Optional | ||
| } else { | ||
| warns = append(warns, errors.New("cgroup v1 support is in maintenance mode")) |
Member
There was a problem hiding this comment.
cgroup -> cgroups
should we say something like:
Suggested change
| warns = append(warns, errors.New("cgroup v1 support is in maintenance mode")) | |
| warns = append(warns, errors.New("cgroup v1 support is in maintenance mode. Please upgrade to cgroups v2")) |
?
Member
Author
There was a problem hiding this comment.
Cgroup v1 support is in maintenance mode, please migrate to Cgroup v2.
According to https://man7.org/linux/man-pages/man7/cgroups.7.html, we should use cgroups.
Member
There was a problem hiding this comment.
yeah cgroups is the right name (plural noun with s)
pacoxu
force-pushed
the
cgroupv1-maintaince-mode
branch
3 times, most recently
from
392ecc5 to
e6b1962
Compare
pacoxu
force-pushed
the
cgroupv1-maintaince-mode
branch
from
e6b1962 to
f66cb6a
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1.31 KEP kubernetes/enhancements#4569