Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on github.com/pkg/errors #34

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Remove dependency on github.com/pkg/errors #34

merged 2 commits into from
Jan 12, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 10, 2023

Fixes #33

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2023
@pacoxu pacoxu force-pushed the pkg-errors-replacing branch 4 times, most recently from 5f92129 to df56b0d Compare January 10, 2023 05:01
@pacoxu
Copy link
Member Author

pacoxu commented Jan 10, 2023

/cc @neolit123

@pacoxu
Remove dependency on github.com/pkg/errors
d24a9dd 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu pacoxu force-pushed the pkg-errors-replacing branch 2 times, most recently from c549a2d to d179b52 Compare January 10, 2023 18:40
neolit123
neolit123 reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@pacoxu pacoxu force-pushed the pkg-errors-replacing branch 2 times, most recently from 911534d to 27b1cdc Compare January 11, 2023 07:11
@pacoxu
update go-format
c2b6b14 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
SataQiu
SataQiu reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a0cb0d1 into kubernetes:master Jan 12, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Mar 7, 2023

Only this PR was merged after the last release v1.8.0. I am not sure if a new release for v1.27 is needed. Either would be OK.
Probably v1.8.1.

@pacoxu pacoxu mentioned this pull request Mar 8, 2023
Closed
6 tasks
@pacoxu pacoxu mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@SataQiu SataQiu SataQiu left review comments

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github.com/pkg/errors is archived
4 participants
@pacoxu @k8s-ci-robot @neolit123 @SataQiu