-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use not "blkio" but "io" controller in cgroups v2 #32
Use not "blkio" but "io" controller in cgroups v2 #32
Conversation
Welcome @orimanabu! |
Hi @orimanabu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cc @KentaTada @pacoxu
PTAL for LGTM
if we merge this it can be considered a bug fix, correct?
/kind bug
We can include it as a PATCH semver here, but backporting the vendor to k/k 1.24 doesn't seem necessary given users can skip the warning. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
https://www.kernel.org/doc/Documentation/cgroup-v2.txt
The "io" controller regulates the distribution of IO resources.
It's my fault. Thanks for the fix.
looks like there is a gofmt error in CI. |
/ok-to-test |
6b59552
to
61dd734
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, orimanabu, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for merging this PR! |
"blkio" controller seems to be available only for cgroups v1 according to man cgroups(7).
See also: #31