Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push the system validators to the new repository #1

Merged
merged 1 commit into from
Nov 4, 2019
Merged

push the system validators to the new repository #1

merged 1 commit into from
Nov 4, 2019

Conversation

neolit123
Copy link
Member

initial validator commit

xref: kubernetes/kubeadm#1638

TODO

  • tag this commit as v1.0.0
  • vendor the repo in k/k and use it for cmd/kubeadm and the node-e2e

@neolit123 neolit123 added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 29, 2019
@neolit123 neolit123 requested review from dims and yastij October 29, 2019 23:05
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 29, 2019
@neolit123
Copy link
Member Author

/approve
?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@neolit123 neolit123 mentioned this pull request Oct 29, 2019
Closed
@neolit123 neolit123 added this to the v1.0 milestone Oct 29, 2019
@yastij
Copy link
Member

yastij commented Oct 29, 2019

/assign

@neolit123
Copy link
Member Author

neolit123 commented Oct 29, 2019 •
edited
Loading

these are just a copy of the k/k 's master at HEAD.
also need to setup some CI, i guess (followup).

@neolit123
Copy link
Member Author

neolit123 commented Oct 30, 2019 •
edited
Loading

/hold
let's wait for #2 to merge and to have the CI added to test-infra

EDIT: kubernetes/test-infra#15026

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2019
@neolit123 neolit123 mentioned this pull request Oct 30, 2019
Merged
@neolit123
Copy link
Member Author

/retest

@neolit123
Copy link
Member Author

/test pull-system-validators-verify

@neolit123
Copy link
Member Author

/hold cancel
need to enable always_run: true for the job

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2019
@neolit123
Copy link
Member Author

@yastij this is ready for review

@yastij
Copy link
Member

yastij commented Oct 31, 2019

@neolit123 - I'll do a pass tomorrow on this

yastij
yastij reviewed Nov 4, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4fc9c1c into kubernetes:master Nov 4, 2019
yastij pushed a commit to yastij/system-validators that referenced this pull request Nov 11, 2019
@k8s-ci-robot @yastij
Merge pull request kubernetes#1 from neolit123/push-validators
24a4ca6 
push the system validators to the new repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij left review comments

@dims dims Awaiting requested review from dims

@ereslibre ereslibre Awaiting requested review from ereslibre

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @yastij @k8s-ci-robot