Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Major Themes responsibility from Release Notes to Comms #2492

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

katcosgrove
Copy link
Contributor

What type of PR is this:

/kind cleanup
/kind documentation

What this PR does / why we need it:

The collection of Major Themes is currently handled by Release Notes, when it is more in line with the duties of the Comms team and most prominently consumed by the Comms team. To better reflect the actual behavior of the teams, I have moved the primary responsibility for collection of Major Themes to Comms, and put Release Notes in a supporting role for this duty.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2024
@katcosgrove
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@katcosgrove
Copy link
Contributor Author

/assign @a-mccarthy

Since you are the incoming Comms lead, this will affect you. Thoughts?

@a-mccarthy
Copy link
Contributor

Sounds good to me. I think it makes sense to move over the responsibility to comms since we are the primary folks using this content for our release deliverables. 👍

@katcosgrove katcosgrove added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 25, 2024
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this proposal.
Thanks, Kat for organizing this.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove, ramrodo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@katcosgrove
Copy link
Contributor Author

/unhold

Thanks y'all!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit d225e69 into kubernetes:master Apr 26, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 26, 2024
@fsmunoz
Copy link
Contributor

fsmunoz commented Apr 26, 2024

Late to the party, but completely in agreement with the proposal, this was one of the suggestions I had for the 1.29 retro since the current situation is an artefact of how things were done in the beginning (when Release Notes were the single source of updates for a release, before there was a release blog), this suggestions greatly clarifies things and puts them in line with current practices.

/lgtm

Copy link

@shopdrop1 shopdrop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants