Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Initial commit of Golang update handbook #1109

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jun 9, 2020

What type of PR is this:

/kind documentation
/area dependency

What this PR does / why we need it:

Initial commit of Golang update handbook

Signed-off-by: Stephen Augustus saugustus@vmware.com
/assign @tpepper @Verolop @markyjackson-taulia
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Tearing down a doc and leaving these related comments on this issue, to keep+track:

1.21 Actions

  • Aiming to get this done in 1.21 and prepare Golang policy for 1.22 handoff
  • Involves knowledge exchange/training. Want to have a framework to bring in more people in for 1.21
  • TBD: We have no real, concrete Golang acceptance criteria—should we use this effort to define them?

Additional Context note
Golang updates are easy to track mechanically, but we also need to follow/read the Golang release notes. Also don’t know all the ins and outs of what’s up in k/k. But these are interesting as both will require cherrypicks. Expected behavior you’d expect to see on master branch for Golang update-related cherrypick could be very different.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from dougm and listx June 9, 2020 05:04
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2020
@justaugustus
Copy link
Member Author

Currently a WIP, with minimal technical details, but tagging you all to "watch this space": @liggitt @dims @BenTheElder @cblecker

@justaugustus
Copy link
Member Author

Reminder to remove/update reference: https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#upgrading-go

Thanks @nikhita!
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1595349083085500

@justaugustus
Copy link
Member Author

@Verolop and I are going to pair on this documentation.
She's got some notes that I'll layer in once she pushes up a branch on top of this skeleton.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2021
@warmchang
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in release engineering meeting, approving this so folks like @cpanato and @ameukam can iterate. @justaugustus feel free to remove WIP label for merge when ready.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

@justaugustus we discussed in the meeting to merge this one as is and iterate on it.
/lgtm

@saschagrunert saschagrunert changed the title [WIP] releng: Initial commit of Golang update handbook releng: Initial commit of Golang update handbook Apr 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4d4ce26 into kubernetes:master Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants