Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone maintenance enhancements #2386

Open
1 of 2 tasks
saschagrunert opened this issue Dec 4, 2023 · 10 comments
Open
1 of 2 tasks

Milestone maintenance enhancements #2386

saschagrunert opened this issue Dec 4, 2023 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Dec 4, 2023 •
edited
Loading

Main improvements are right now:

Tasks
Beta Give feedback

Original conversation: https://kubernetes.slack.com/archives/C2C40FMNF/p1700057962137919

cc @kubernetes/release-managers @pohly @Priyankasaggu11929
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Dec 4, 2023
@saschagrunert saschagrunert added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Dec 4, 2023
@xmudrii
Copy link
Member

xmudrii commented Dec 4, 2023

Clear the latest milestone on master PR's if they got applied before code freeze

I'm not sure if Prow plugin is the best fit for that. Plugins usually react to an event (received via GitHub Webhooks) for a concrete PR. While it's technically doable to remove milestone from multiple PRs, I'm slightly concerned about issues that might arise from that (e.g. concurrency issues).

I think it would be better to have a ProwJob to handle that, but we would need to handle credentials for GitHub in some way.

Check that PRs have lgtm and approved labels before applying the latest milestone during code freeze

This is not going to solve another part of the issue: someone who isn't on the release team can use /milestone to set the milestone and get the PR merged without ACK from the Release Team Leads. I think it might be better to change the plugin that handles the /milestone command to restrict who can apply certain milestones. For example, once the code freeze is in effect, the latest milestone can be set on PRs only by the Release Team Leads and the Release Team Release Signal team. This is something similar to what we did for the cherry-pick-approve plugin recently.

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 4, 2023 •
edited
Loading

I think it would be better to have a ProwJob to handle that

Something similar to the ci-fast-forward job would work: https://github.com/kubernetes/test-infra/blob/94bd5f880ecc866b2076c116a017f55d80cf6906/config/jobs/kubernetes/sig-k8s-infra/trusted/releng/releng-trusted.yaml#L338-L368

For example, once the code freeze is in effect, the latest milestone can be set on PRs only by the Release Team Leads and the Release Team Release Signal team.

I added the people restriction to the first comment. The main issue was that the milestone got applied before code freeze, which can be addressed with the first point.

@saschagrunert saschagrunert changed the title Clear milestones on PRs testfreeze prow plugin Milestone maintenance enhancements Dec 5, 2023
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 5, 2023 •
edited
Loading

Update the issue to reflect the current state. One problem I see right now is that code freeze is nothing we can check from a technical perspective. 🤔

Edit: Ah we could check for the prow config: https://github.com/kubernetes/test-infra/pull/31164/files

saschagrunert added a commit to saschagrunert/test-infra that referenced this issue Dec 6, 2023
@saschagrunert
Add code_freeze_maintainers_team option to milestone prow plugin
5248cb0 
The new option allows to set a specific team (like the
release-team-leads) to  be milestone maintainer when code freeze is in
place. For that we extend the milestone plugin to be able to validate
codefreeze based on the tide configuration of the repository.

Ref:

- kubernetes/sig-release#2386

PRs for code freeze updates:
- kubernetes#31164
- kubernetes#29259

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue Dec 6, 2023
Closed
saschagrunert added a commit to saschagrunert/test-infra that referenced this issue Dec 6, 2023
@saschagrunert
Add code_freeze_maintainers_team option to milestone prow plugin
7988852 
The new option allows to set a specific team (like the
release-team-leads) to  be milestone maintainer when code freeze is in
place. For that we extend the milestone plugin to be able to validate
codefreeze based on the tide configuration of the repository.

Ref:

- kubernetes/sig-release#2386

PRs for code freeze updates:
- kubernetes#31164
- kubernetes#29259

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/test-infra that referenced this issue Dec 6, 2023
@saschagrunert
Add code_freeze_maintainers_team option to milestone prow plugin
47348d8 
The new option allows to set a specific team (like the
release-team-leads) to  be milestone maintainer when code freeze is in
place. For that we extend the milestone plugin to be able to validate
codefreeze based on the tide configuration of the repository.

Ref:

- kubernetes/sig-release#2386

PRs for code freeze updates:
- kubernetes#31164
- kubernetes#29259

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 5, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 4, 2024
@xmudrii
Copy link
Member

xmudrii commented Apr 5, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 5, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2024
@xmudrii
Copy link
Member

xmudrii commented Jul 22, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2024
@xmudrii
Copy link
Member

xmudrii commented Oct 21, 2024

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@saschagrunert @xmudrii @k8s-ci-robot @k8s-triage-robot