Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove README and LICENSE #1

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Remove README and LICENSE #1

merged 1 commit into from
Oct 25, 2017

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Oct 20, 2017 •
edited
Loading

@k8s-ci-robot k8s-ci-robot requested review from munnerz and sttts October 20, 2017 11:01
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2017
@munnerz
Copy link
Member

munnerz commented Oct 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2017
@nikhita nikhita mentioned this pull request Oct 20, 2017
Closed
@munnerz
Copy link
Member

munnerz commented Oct 20, 2017

/approve

@munnerz
Copy link
Member

munnerz commented Oct 20, 2017

Not sure how to trigger merges on this repo.. I guess because we haven't synced OWNERS yet, nobody is an owner?

@nikhita
Copy link
Member Author

nikhita commented Oct 20, 2017

I guess because we haven't synced OWNERS yet, nobody is an owner?

Yeah, mostly only the people with write access can merge it.

@sttts
Copy link
Contributor

sttts commented Oct 20, 2017

I would prefer to slowly switch to have these files in the staging repo. For sample-apiserver this is already the case. In other words, instead of extending the files here, we have to delete them. The sync will bring them back.

@nikhita
Copy link
Member Author

nikhita commented Oct 20, 2017

In other words, instead of extending the files here, we have to delete them.

Do you want me to delete the files in this PR then? Or just let it be how it is for now?

@sttts
Copy link
Contributor

sttts commented Oct 23, 2017

Do you want me to delete the files in this PR then? Or just let it be how it is for now?

Would be good. We should do that for all repos but client-go.

@nikhita nikhita mentioned this pull request Oct 23, 2017
Closed
@nikhita
Remove README and LICENSE
d2bf9b0 
We should use the staging files instead of having some files
authoritative in the external repo. Otherwise, we complicate the
publishing process as it has to know which files come from the latter.

`README.md` and `LICENSE` are authoritative in external repos.
We should move them to staging.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2017
@nikhita nikhita changed the title Update README with details Remove README and LICENSE Oct 23, 2017
@nikhita
Copy link
Member Author

nikhita commented Oct 23, 2017

@sttts Updated to remove the files.

@nikhita nikhita mentioned this pull request Oct 23, 2017
Merged
@sttts sttts merged commit a5a4aad into kubernetes:master Oct 25, 2017
@nikhita nikhita deleted the update-readme branch December 18, 2017 12:22
mattmoor referenced this pull request in mattmoor/k8s-sample-controller Jan 6, 2018
@grantr
Merge pull request #1 from grantr/dep
4e4f336 
Replace godep with dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

@sttts sttts Awaiting requested review from sttts

Assignees

@munnerz munnerz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhita @munnerz @sttts @k8s-ci-robot