-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kazel: Use GoPrefix for openapi base import #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows subprojects like federation to generate for openapi.
Closed
4 tasks
/lgtm have you manually tested this? |
@ixdy Yes, I've manually tested this with both k/k and k/f (by targeting my branch's commit). |
great, thanks! |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing
sttts
pushed a commit
to sttts/apimachinery
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/api
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/apiserver
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/kube-aggregator
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/sample-apiserver
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/sample-controller
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/apiextensions-apiserver
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/metrics
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
sttts
pushed a commit
to sttts/code-generator
that referenced
this pull request
Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
tamalsaha
pushed a commit
to gomodules/encoding
that referenced
this pull request
Aug 10, 2021
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this pull request
Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 54081, 54271, 51783, 54600, 54594). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update to latest kube-openapi and kazel - update vendored kube-openapi to include kubernetes/kube-openapi#14 - update hash of repo infra used for bazel generation so kazel includes kubernetes/repo-infra#48 This is the final step in enabling federation to generate openapi code for itself and vendored kube (#54335). /sig multicluster testing Kubernetes-commit: 3f5f9c3df96618f6fc447fc98d9fc7ba97b0e333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows subprojects like federation to generate for openapi as per kubernetes/kubernetes#54335.
cc: @mbohlool