Skip to content

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 15, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: Build 1.25.0 images

/hold
/assign @saschagrunert @ameukam @puerco @MadhavJivrajani
cc @kubernetes/release-managers @liggitt

Which issue(s) this PR fixes:

xref #3957

Special notes for your reviewer:

Does this PR introduce a user-facing change?

golang: Build 1.25.0 images

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 15, 2025
@cpanato cpanato mentioned this pull request Aug 15, 2025
29 tasks
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2025
@ameukam
Copy link
Member

ameukam commented Aug 15, 2025

/lgtm
we may want to think about Debian Trixie: https://wiki.debian.org/DebianTrixie

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2025
@cpanato
Copy link
Member Author

cpanato commented Aug 15, 2025

lets look on that after this

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2025
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/retest

@cpanato
Copy link
Member Author

cpanato commented Aug 18, 2025

humm

docker.io/library/golang:1.25.0-bullseye

does not exist only

1.25.0-bookworm
or 
1.25.0-trixie

But the image that is using it is kube-cross, and iffi, remember correctly, the bookworm has a breaking change for the kubelet

Should we upgrade to Bookworm and see what the breaks are, or move to Trixie?

cc @dims @saschagrunert @liggitt

@saschagrunert
Copy link
Member

Related to #3246

The reason to use bullseye was the lower glibc version constraint (2.31). Now using bookworm will increase that version to 2.36 and trixie ships 2.41.

@k8s-ci-robot
Copy link
Contributor

@cpanato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-release-image-kube-cross 985d166 link true /test pull-release-image-kube-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants